EricssonResearch / scream

SCReAM - Mobile optimised congestion control algorithm
BSD 2-Clause "Simplified" License
174 stars 53 forks source link

Latest version is overshooting #9

Open ggarber opened 7 years ago

ggarber commented 7 years ago

I upgraded the scream version to latest version and now it is overshooting. I always test this connecting a desktop client to an iphone client and simulating different bandwidth constraints in the iphone device with Network Link Conditioner.

With previous version (1-2 months ago old) it is never overshooting (even if estimation can be sometimes 100kbps below the configured bandwidth).

With the new version (today) it overshoots many times (f.e. simulating 200 kbps I'm getting 350-400 kbps constantly now).

I'm rolling back to the previous version but I'm reporting it just in case it helps.

PD. Maybe there is a new API or I should be using the new version in a different way, but I don't think it is the case.

IngJohEricsson commented 7 years ago

Hi Do you see the overshoot problem in the latest version ?

wujin1989 commented 3 years ago

hihi When the bandwidth is limited to 1Mbps, call getTargetBitrate to get a value much larger than 1Mbps With My MultiMedia Code . Encoder: libx264 ABR Try Use scream bw test tool , it's normal by limited to 1Mbps.

This case is normal or not? Scream algorithm issue or The problem of SW encoder ABR instability

IngJohEricsson commented 3 years ago

Hi

Sorry for the delay. Based on your email I don’t know what kind of setup you are running. Is it the SCReAM BW test tool or the gstreamer plugins ?

/Ingemar

From: wujin1989 @.> Sent: den 11 maj 2021 10:43 To: EricssonResearch/scream @.> Cc: Ingemar Johansson S @.>; Comment @.> Subject: Re: [EricssonResearch/scream] Latest version is overshooting (#9)

hihi When the bandwidth is limited to 1Mbps, call getTargetBitrate to get a value much larger than 1Mbps With My MultiMedia Code . Encoder: libx264 ABR Try Use scream bw test tool , it's normal by limited to 1Mbps.

This case is normal or not? Scream algorithm issue or The problem of SW encoder ABR instability

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://protect2.fireeye.com/v1/url?k=bbb1fe45-e42ac740-bbb1bede-86959e472243-f0e9a7254223e16b&q=1&e=62984646-6a35-4135-bc8a-d8256e630f31&u=https%3A%2F%2Fgithub.com%2FEricssonResearch%2Fscream%2Fissues%2F9%23issuecomment-838085618 , or unsubscribe https://protect2.fireeye.com/v1/url?k=d8e2a80e-8779910b-d8e2e895-86959e472243-bcf0018d063318b3&q=1&e=62984646-6a35-4135-bc8a-d8256e630f31&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACRZ2GCMLPPLVIXY6ERUQZTTNDUXXANCNFSM4DOEJPTA . https://github.com/notifications/beacon/ACRZ2GDHE4ZVYF6FJVAKWFTTNDUXXA5CNFSM4DOEJPTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGH2CX4Q.gif

wujin1989 commented 3 years ago

Hi

I use scream in my media client and server program, and the client sends the code stream to the server. Client runs sender The server runs the receiver

The client calls the getTargetBitrate() function and then sets it to the encoder. The target bitrate is normal at the beginning in fast mode, when it is close to the limited bandwidth, but it will always exceed the limited bandwidth. For example, the bandwidth is limited to 1Mbps, but the getTargetBitrate() may rush to 1.6Mbps.

This case if normal or not?

IngJohEricsson commented 3 years ago

Hi

It is possible that the max bitrate is not configured correctly.

Please see parameter list at https://github.com/EricssonResearch/scream/blob/master/code/ScreamTx.h#L135

/Ingemar

From: wujin1989 @.> Sent: den 21 maj 2021 11:56 To: EricssonResearch/scream @.> Cc: Ingemar Johansson S @.>; Comment @.> Subject: Re: [EricssonResearch/scream] Latest version is overshooting (#9)

Hi

I use scream in my media client and server program, and the client sends the code stream to the server. Client runs sender The server runs the receiver

The client calls the getTargetBitrate() function and then sets it to the encoder. The target bitrate is normal at the beginning in fast mode, when it is close to the limited bandwidth, but it will always exceed the limited bandwidth. For example, the bandwidth is limited to 1Mbps, but the getTargetBitrate() may rush to 1.6Mbps.

This case if normal or not?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://protect2.fireeye.com/v1/url?k=775b2f46-28c01643-775b6fdd-86d2114eab2f-cc0575f6e4aecfb1&q=1&e=45dae0eb-6548-45b0-bced-441dd4c96bbb&u=https%3A%2F%2Fgithub.com%2FEricssonResearch%2Fscream%2Fissues%2F9%23issuecomment-845834052 , or unsubscribe https://protect2.fireeye.com/v1/url?k=05714463-5aea7d66-057104f8-86d2114eab2f-0f1bd96a2b2bc1b3&q=1&e=45dae0eb-6548-45b0-bced-441dd4c96bbb&u=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACRZ2GDCEWDZGTDTFL44SR3TOYUZ3ANCNFSM4DOEJPTA . https://github.com/notifications/beacon/ACRZ2GBKRCV2UTUKSZVA7XLTOYUZ3A5CNFSM4DOEJPTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGJVGORA.gif