EricssonResearch / spindump

Spindump is an in-network latency measurement tool with support for QUIC and TCP
BSD 3-Clause "New" or "Revised" License
61 stars 17 forks source link

Fix compilation error on Ubuntu 20.04 (enum conversion) #211

Closed SPYFF closed 4 years ago

SPYFF commented 4 years ago

When I tried to compile it on Ubuntu 20.04 (GCC 10) I got the following error:

spyff@hp:~/Dokumentumok/spindump$ make
[ 86%] Built target spindumplib
[ 89%] Built target spindump_test
[ 90%] Building C object src/CMakeFiles/spindump.dir/spindump_main_lib.c.o
/home/spyff/Dokumentumok/spindump/src/spindump_main_lib.c: In function ‘spindump_main_processargs’:
/home/spyff/Dokumentumok/spindump/src/spindump_main_lib.c:674:28: error: implicit conversion from ‘enum <anonymous>’ to ‘enum <anonymous>’ [-Werror=enum-conversion]
  674 |       aggregate->side2type = side2type;
      |                            ^
/home/spyff/Dokumentumok/spindump/src/spindump_main_lib.c: At top level:
cc1: note: unrecognized command-line option ‘-Wno-documentation’ may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option ‘-Wno-reserved-id-macro’ may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option ‘-Wno-documentation-deprecated-sync’ may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option ‘-Wno-disabled-macro-expansion’ may have been intended to silence earlier diagnostics
cc1: note: unrecognized command-line option ‘-Wno-covered-switch-default’ may have been intended to silence earlier diagnostics
cc1: all warnings being treated as errors
make[2]: *** [src/CMakeFiles/spindump.dir/build.make:92: src/CMakeFiles/spindump.dir/spindump_main_lib.c.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:588: src/CMakeFiles/spindump.dir/all] Error 2
make: *** [Makefile:141: all] Error 2

I fixed it with an introduction of an enum name. Maybe not too descriptive, but I can rename it to anything else.