Open sourcery-ai[bot] opened 2 years ago
β Merging this PR will increase code quality in the affected files by 0.02%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 5.27 β | 5.24 β | -0.03 π |
Method Length | 60.77 β | 60.33 β | -0.44 π |
Working memory | 8.11 π | 8.15 π | 0.04 π |
Quality | 69.39% π | 69.41% π | 0.02% π |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 635 | 632 | -3 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
src/quantifiedme/activitywatch.py | 60.27% π | 60.30% π | 0.03% π |
src/quantifiedme/influxdb.py | 88.92% β | 88.20% β | -0.72% π |
src/quantifiedme/load_toggl.py | 59.04% π | 59.50% π | 0.46% π |
src/quantifiedme/qslang.py | 74.49% π | 74.68% π | 0.19% π |
tests/test_load.py | 82.29% β | 82.29% β | 0.00% |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
src/quantifiedme/activitywatch.py | load_complete_timeline | 16 π | 247 β | 14 π | 33.94% π | Try splitting into smaller methods. Extract out complex expressions |
src/quantifiedme/load_toggl.py | _load_toggl | 12 π | 220 β | 15 π | 37.62% π | Try splitting into smaller methods. Extract out complex expressions |
src/quantifiedme/qslang.py | load_df | 13 π | 191 π | 8 π | 51.00% π | Try splitting into smaller methods |
src/quantifiedme/activitywatch.py | create_fake_events | 5 β | 113 π | 11 π | 60.41% π | Extract out complex expressions |
src/quantifiedme/load_toggl.py | _load_toggl.entries_from_all_workspaces | 1 β | 77 π | 10 π | 71.30% π | Extract out complex expressions |
The emojis denote the absolute quality of the code:
The π and π indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
Merging #6 (722cb45) into master (77ea816) will decrease coverage by
0.14%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## master #6 +/- ##
==========================================
- Coverage 60.14% 60.00% -0.15%
==========================================
Files 4 4
Lines 281 280 -1
==========================================
- Hits 169 168 -1
Misses 112 112
Impacted Files | Coverage Ξ | |
---|---|---|
src/quantifiedme/load_toggl.py | 21.27% <0.00%> (ΓΈ) |
|
src/quantifiedme/qslang.py | 56.79% <33.33%> (ΓΈ) |
|
src/quantifiedme/activitywatch.py | 70.00% <83.33%> (-0.23%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update 77ea816...722cb45. Read the comment docs.
Branch
master
refactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
master
branch, then run:Help us improve this pull request!