Add nodeRightClick - Githubissues

ErikGartner / dTree

A library for visualizing data trees with multiple parents, such as family trees. Built on top of D3.

https://treehouse.gartner.io/ErikGartner/58e58be650453b6d49d7

MIT License

509 stars 136 forks source link

Add nodeRightClick #87

Closed richchurcher closed 5 years ago

richchurcher commented 5 years ago

This:

[x] Adds a nodeRightClick callback, which I needed for a project and seems a sensible default option
[x] Removes the now-deprecated JSCS linter. It merged with eslint, which is already in the build pipeline. It was causing unnecessary build errors related to spaces before argument lists.
[x] Updates the demo to show right-clicks (and use alert, in case folks don't have the console open).

Thanks very much for dTree!

ErikGartner commented 5 years ago

Hi,

Sorry for late response, I've been very busy at work. Glad you like dTree and thanks for your contribution!

I agree that more than left click should be possible. I'll look through your pull request after my deadlines. One thought is to have some generic click method that takes button number, so as to allow for scroll-click too. But that is perhaps not too important.

Anyway, thanks again for contributing!

/Erik

ErikGartner commented 5 years ago

Sorry for the long review time. Everything looks great! :-)