search

ErikHen / PictureRenderer

Simplify the rendering of HTML Picture elements for ASP.Net. With support for responsive, lazy loaded images.
MIT License
4 stars 5 forks source link

Change some classes from Internal to public #19

Closed LindebergC closed 9 months ago

LindebergC commented 10 months ago

I have some clients that used https://github.com/vnbaaij/ImageProcessor.Web.Episerver for cms 11, that used some methods in PictureUtils.

It would be nice to be able to use some of the methods in the class PictureUtils but the class is Internal, would it be possible to change that to public for PictureUtils and PictureData?

ErikHen commented 10 months ago

Hi. Sure, that can be done. What methods do you want to use?

LindebergC commented 10 months ago

Wonderful! :)

Mainly GetPictureData, but that is already public but I was thinking of

internal static class PictureUtils

to public static class PictureUtils

and internal class PictureData

to public class PictureData

ErikHen commented 10 months ago

Hi. Update to v3.11 and see if that works for you. I'm curious why you want to do this. Do you render an img/picture element yourself?

LindebergC commented 10 months ago

Thank you Erik! It works like a charm!

Yes you are right, in some places I need to render just the img element, one example is for the meta property="og:image" for facebook.