search

ErikKusch / KrigR

An R Package for downloading, preprocessing, and statistical downscaling of the European Centre for Medium-range Weather Forecasts ReAnalysis 5 (ERA5) family provided by the European Centre for Medium‐Range Weather Forecasts (ECMWF).
MIT License
104 stars 24 forks source link

download_DEM: filename for target DEM is incorrect #46

Closed sambo1972 closed 1 year ago

sambo1972 commented 1 year ago

The filename at this line (https://github.com/ErikKusch/KrigR/blob/243c8768ac6b91ccb87e4f792eca75f854e5614a/R/download.R#L617C75-L617C75) is the same as in the previous line - i.e. : "GMTED2010_Train.nc".

Consequently the training file is immediately overwritten with the target DEM - looks like a simple copy & paste error.

ErikKusch commented 1 year ago

Hiya Sam,

thanks for pointing this out. Could you give me additional information where you ran into that issue? It looks like this would be in the training material?

Cheers, Erik

ErikKusch commented 1 year ago

Nevermind - I should have just clicked the link you provided :-D Thank you very much for this. Issue is fixed with #47. Reinstalling will provide you with the fix. Thank you so much!