ErikNatanael / knyst

Apache License 2.0
34 stars 4 forks source link

WIP: Fix miri errors (undefined behaviour and data race) #5

Closed ErikNatanael closed 2 years ago

ErikNatanael commented 2 years ago

Resolves the errors reported by miri, brought to my attention by @harudagondi. Fixes #3.

harudagondi commented 2 years ago

Btw, I ran miri again, and this leaked memory. Like a lot of memory. I piped the error output into a log file and it is 94669 lines long.

harudagondi commented 2 years ago

Here's the interesting part:

alloc4068091 (Rust heap, size: 98400, align: 8)

What are you even allocating here? Why is the allocation that big? lol

harudagondi commented 2 years ago

There are also a lot of allocations with sizes 512, 3200, 9600, and others.

ErikNatanael commented 2 years ago

I saw, haven't gotten to that one yet :)