ErikNixdorf / sbat

The Repo for the Surface Water Balance Analysis Tool
BSD 3-Clause "New" or "Revised" License
3 stars 0 forks source link

Setting baseflow method 'demuth' fails and yields error #35

Closed MarcoHannemann closed 1 year ago

MarcoHannemann commented 1 year ago

In #29 sbat.yaml configuration was changed and the methods for baseflow was set to demuth instead of UKIH and fixed. This breaks the functionality and throws an exception.

I guess this has something to do with no falling limbs available for the input data?

This is the traceback:

Traceback (most recent call last):
  File "/home/hannemam/Projects/sbat/sbat/sbat.py", line 571, in <module>
    main()
  File "/home/hannemam/Projects/sbat/sbat/sbat.py", line 551, in main
    sbat.get_recession_curve()
  File "/home/hannemam/Projects/sbat/sbat/sbat.py", line 368, in get_recession_curve
    df_metrics = pd.concat(metrics, axis=0)
  File "/home/hannemam/Projects/envs/sbat/lib/python3.9/site-packages/pandas/util/_decorators.py", line 331, in wrapper
    return func(*args, **kwargs)
  File "/home/hannemam/Projects/envs/sbat/lib/python3.9/site-packages/pandas/core/reshape/concat.py", line 368, in concat
    op = _Concatenator(
  File "/home/hannemam/Projects/envs/sbat/lib/python3.9/site-packages/pandas/core/reshape/concat.py", line 425, in __init__
    raise ValueError("No objects to concatenate")
ValueError: No objects to concatenate

sbat.py L345 is never reached, therefore metric stays empty and the concatenation error happens.

I also suggest to set the configuration file to the old state, as this has nothing to do with type hints/docstrings #29 was addressing.