ErikPDev / AdvanceDeaths

A plugin to customize the death messages!
MIT License
18 stars 6 forks source link

Crash #20

Closed Tuvqlu closed 2 years ago

Tuvqlu commented 2 years ago
  1. Leaderboards do not work
  2. Kill phrases don’t work
  3. Nothing basically works
ErikPDev commented 2 years ago

Hey! I’m currently overseas and I can’t code on my phone lol.

Which version of pocketmine are you using?

Tuvqlu commented 2 years ago

Sure! I really want this plugin because it would make my server a lot more fun! So, I am using pocketmine 4.07 or whatever the most recent version is. Thankyou for the quick reply!

ErikPDev commented 2 years ago

Your welcome! Are there any crashes or error logs, make sure to add them.

Make sure you have configured AdvanceDeaths correctly.

Tuvqlu commented 2 years ago

I took it off my server becuase it was getting frustrating not working, but today I’ll try it again and send you the log. I just added some kill phrases, and leaderboards.

ErikPDev commented 2 years ago

I took it off my server becuase it was getting frustrating not working, but today I’ll try it again and send you the log. I just added some kill phrases, and leaderboards.

Alright! Take your time :p

Tuvqlu commented 2 years ago

Yeah, have you tested out those features in the current version, and they work? Does it require mysql or one of those datebsses?

ErikPDev commented 2 years ago

Yeah, have you tested out those features in the current version, and they work?

I’ve tested AdvanceDeaths with PM4 to update it. It works fine, maybe there’s an api change but I’m not sure since I don’t have my laptop with me for over 3 weeks.

Tuvqlu commented 2 years ago

Does it require database ?

ErikPDev commented 2 years ago

Does it require database ?

It uses a SQLite database by default located on the configuration folder of AdvanceDeaths.

Tuvqlu commented 2 years ago

I haven’t added any databases, do I need to download mysql or SQLite for it to work?

ErikPDev commented 2 years ago

I haven’t added any databases, do I need to download mysql or SQLite for it to work?

It should work by default.

Tuvqlu commented 2 years ago

Here’s the crash :/ AE207DE8-54DB-4D4B-A43E-239D00D2481B

ErikPDev commented 2 years ago

Oops, I forgot to change Level to World.

Unfortunately, I can’t code atm but I’ll figure something out.

ErikPDev commented 2 years ago

Hey @Tuvqlu, may you test the latest build? https://poggit.pmmp.io/ci/ErikPDev/AdvanceDeaths/AdvanceDeaths/dev:93

Tuvqlu commented 2 years ago

Sure I hope it works : D. Also, does the scoreboard tags work with scorehud for api 4.0.0?Hope so 😄

ErikPDev commented 2 years ago

Sure I hope it works : D. Also, does the scoreboard tags work with scorehud for api 4.0.0?Hope so 😄

Unfortunately, there isn’t any public scoreboard plugins on poggit for PM4 so I can’t implement a support for it yet. ScoreHud is supported on PM3.

Tuvqlu commented 2 years ago

You should make a level system plugin that would be pretty cool

Tuvqlu commented 2 years ago

Uh ![Uploading 77E21989-761C-41C8-89F1-FD2038E4A637.jpeg…]()

ErikPDev commented 2 years ago

?, I can’t see that image.

Tuvqlu commented 2 years ago

CF64366F-014F-45AD-8FCF-8F55686E29BE Oh my bad, here.

ErikPDev commented 2 years ago

Are you using the latest release? You should use the latest dev build. https://poggit.pmmp.io/r/160983/AdvanceDeaths_dev-93.phar

Tuvqlu commented 2 years ago

Yes, i was using this: FE8DBFAD-DED8-4F7B-A6F6-48498E43B0DE

ErikPDev commented 2 years ago

That can’t be true, may you double check?

Tuvqlu commented 2 years ago

Yes, I deleted config, readded that plugin just now, activated leaderboard, and:image Big crash.

ErikPDev commented 2 years ago

That error is different than the screenshot you sent me. Looking into it

ErikPDev commented 2 years ago

Made some changes, may you try the latest dev build again?

Tuvqlu commented 2 years ago

Sure is it, build #96?

ErikPDev commented 2 years ago

97 actually

Tuvqlu commented 2 years ago

K just downloaded. Loading now. Should the kill phrases work as well? And do I need to enter a password and username for MySQL?

ErikPDev commented 2 years ago

K just downloaded. Loading now. Should the kill phrases work as well? And do I need to enter a password and username for MySQL?

There are two options, SQLite(faster) or MySQL. I’ll recommend using SQLite.

Tuvqlu commented 2 years ago

Okay!

Tuvqlu commented 2 years ago

We should apply for a world record of longest GitHub issue lol

ErikPDev commented 2 years ago

I’ve also noticed a bunch of other bugs which I’m not sure how I didn’t notice them. I’ll fix them in 3-5 days.

Tuvqlu commented 2 years ago

Another crash, something different this time though,image

ErikPDev commented 2 years ago

Yeah, I’ll have to completely update it to PM4 again. I’ll be back home at 3-5 days then I’m able to do it.

Tuvqlu commented 2 years ago

K have a great rest of your trip

ErikPDev commented 2 years ago

Thanks, I'm back home now. Try out this dev build https://poggit.pmmp.io/ci/ErikPDev/AdvanceDeaths/~/dev:98

Tuvqlu commented 2 years ago

Hasn't crashed yet, I'm going to test it out when I get home later

I have a good idea for a future update:

Levels make things worth doing! Cosmetics make levels worth getting! Also, different settings per world, different leaderboards per world, different cosmetics per world

Great plugin

Tuvqlu commented 2 years ago

Erik, one more crash, I think it's from the particles:image image

ErikPDev commented 2 years ago

Fixed on the latest dev build

ErikPDev commented 2 years ago

Update me btw :p

Tuvqlu commented 2 years ago

Ofc bro 5 stars

ErikPDev commented 2 years ago

I meant if it's working or not

Tuvqlu commented 2 years ago

OHH lol I will

Tuvqlu commented 2 years ago

Still crashes image

ErikPDev commented 2 years ago

I'm officially switching ide's.

ErikPDev commented 2 years ago

OKay, made a few visible changes in my ide. Try the latest build again :p

ErikPDev commented 2 years ago

Closing in a few hours due to inactivity