ErikReider / SwayNotificationCenter

A simple GTK based notification daemon for SwayWM
GNU General Public License v3.0
1.17k stars 60 forks source link

Notification action brings qbittorrent out of tray #132

Closed 7ff04da4aa6ac37197e249299066ac30 closed 2 years ago

7ff04da4aa6ac37197e249299066ac30 commented 2 years ago

I'm not sure if the issue I'm experiencing is at all related to swaync, but I'd like to ask here just in case. I'll otherwise ask for help at qbittorrent or firefox/librewolf if it turns out this isn't a swaync issue.

I'm on Arch Linux, using sway (obviously) and waybar to display swaync. I haven't messed with the default keybindings, as I'm satisfied with them. Anyway, whenever librewolf issues a notification (such as when using discord or taking a screenshot with its built-in utility), it shows up as a swaync notification. So far, so good. But when I click on the notification with the left mouse button — therefore issuing the default action —, qbittorrent is pulled into the top of the display. The action otherwise works fine (for example, on discord in the browser, clicking has the effect of jumping to the specific chat and message that caused the notification). Ideally, I would like qbittorrent not to appear when clicking an unrelated notification.

This only happens when qbittorrent is minimized to the waybar tray. If it is already "open", this behaviour does not occur. Also, when I send the open qbittorrent window to the scratchpad, mimicking the minimized to tray feature, the issue does not occur. This has been my "fix" for now, though I'd much rather have it sit normally on the tray and only be invoked when actually relevant.

I don't know which logs to attach here, if any. Anyway, sorry if this isn't the place to ask for help, but I'm at a loss here.

ErikReider commented 2 years ago

It sounds like a qbittorrent issue to me... Closing

7ff04da4aa6ac37197e249299066ac30 commented 2 years ago

Actually, after digging around a bit, it has to do with Qt6 and gnome/gtk support

qBittorrent/qBittorrent#17165 qBittorrent/qBittorrent#17054

Just posting this here in case someone else stumbles upon this.

ErikReider commented 2 years ago

So it only happens when you get notifications from Discord or Spotify? Can you find a reproducible testing method? I sent myself a notification and minimized qbittorrent into the tray and clicked the notification, nothing unusual happened

7ff04da4aa6ac37197e249299066ac30 commented 2 years ago

Yes, especifically when those notifications are from the browser. Otherwise, I could only notice this behaviour when playing around with notify-send.py, in which case, weirdly enough, only one of the buttons provided by the default notification example brought qbittorrent out of the notification area.

To reproduce the reported behaviour, you would have to receive a notification from the Discord on the browser (I didn't try this with Spotify) and simultaneously be using qbittorrent compiled with Qt6 support instead of Qt5. Using Qt5 has fixed the issue, for me, but I'm inclined to think that that's not ideal.

Edit: also, sending myself notifications with notify-send do not pull qbittorrent out of the notification tray, like it happened to you.

ErikReider commented 2 years ago

In what browser? Chrome, Firefox?

ErikReider commented 2 years ago

I can actually reproduce this with Discord notifications in Firefox.

Edit: Seems like mako is also affected by this so I'm closing this again. Seems like it's a qbittorrent issue

7ff04da4aa6ac37197e249299066ac30 commented 2 years ago

Yes, that seems to be the case. In case someone has the same issue in the near future (i.e. before qbittorrent gets this fixed), the current workaround is to use a version of qbittorrent compiled with Qt5, not Qt6.