ErikReider / SwayNotificationCenter

A simple GTK based notification daemon for SwayWM
GNU General Public License v3.0
1.17k stars 60 forks source link

[Feature request] Add a state between 'muted' and 'ignored' for 'notification-visibility' #146

Closed rgouicem closed 1 year ago

rgouicem commented 1 year ago

It would be nice to have a state between muted and ignored that:

My use case here is media players that trigger a notification every time they switch track (e.g. Spotify). For this type of applications, I don't want notifications to pop up every time, and I don't want to see a change in my waybar module either. However, I still want to see which track is playing when I open the notification center.

I can try looking into this when I have some time. But from what I have seen, it would require to distinguish between different types of notifications (this new state and others) when generating the json for waybar. And currently, it's just taking the size of the list of notifications.

ErikReider commented 1 year ago

Could you elaborate on "I don't want to see a change in my waybar module either". So you want the Spotify notification to exist in the Control Center while the custom waybar module thinks that the Control Center is empty?

rgouicem commented 1 year ago

Exactly. My waybar module (more or less the one in the readme) turns red when there is a notification in the control center. But I don't want Spotify notifications to turn the module red, because these notifications are a bit irrelevant to me (they happen every time the song changes). However, when I open the control center, I still want to see which song is playing. I only want to have a visual cue in the waybar module when there is a "real" notification (email, etc...).

I think having a new state would be a good solution, but you may have a better idea on how to obtain this behavior.

Additionally, in the future, I'd like to try and implement some kind of media player widget in the control center that would stay "pinned" there, with some media controls (play/pause, next, prev). But this is a bit irrelevant for this issue I think.

ErikReider commented 1 year ago

I'm back from my vacation. I'll look into this :)

ErikReider commented 1 year ago

I can't really think of a good use case for this except for music player notifications which would be worse than a player widget in Waybar or even in the Control Center. I'll close this for now...

I'd gladly accept a media player widget :)

ErikReider commented 1 year ago

150 should make it a lot easier to create widgets