search

ErikReider / SwayNotificationCenter

A simple GTK based notification daemon for SwayWM
GNU General Public License v3.0
1.3k stars 62 forks source link

Audio slider #207

Closed JannisPetschenka closed 1 year ago

JannisPetschenka commented 1 year ago

Got the next PR already prepared :) It should be a bit more straight forward since it's pretty much just your code from SwaySettings with some stuff removed ;)

ErikReider commented 1 year ago

Hmm... Maybe I'll just move the installation of the needed packages into the respective action. Seems easier than hosting a docker image that I usually forget to update

JannisPetschenka commented 1 year ago

Hmm... Maybe I'll just move the installation of the needed packages into the respective action. Seems easier than hosting a docker image that I usually forget to update

True, might be easier.. But here is a way to do it via an action GitHub Docker action.. I could look into it a bit more next weekend if you'd like.

ErikReider commented 1 year ago

True, might be easier.. But here is a way to do it via an action GitHub Docker action.. I could look into it a bit more next weekend if you'd like.

Wouldn't the main image be updated then? Or can you create different sub-tags and delete them on merge?

JannisPetschenka commented 1 year ago

Wouldn't the main image be updated then? Or can you create different sub-tags and delete them on merge?

Hmm true.. you could build/use the images locally in the action when on sub-branches and only push to docker-hub when on main. But I think that would still be a bad idea since that would mean you'd push the images everytime you push to main. Even if there were no changes to the dockerfiles (which I assume is the case 90% of the time). So manually might be the way to go :)

JannisPetschenka commented 1 year ago

Fixed the issues and added the additional dependencies to the build files, should hopefully work now :)