ErikReider / SwayNotificationCenter

A simple GTK based notification daemon for SwayWM
GNU General Public License v3.0
1.3k stars 62 forks source link

Add inline replies to notifications #221

Closed ErikReider closed 1 year ago

ErikReider commented 1 year ago

Fixes: #179

Had to do a lot of tweaking in this PR due to a Notification essentially being a GtkButton with content inside of it. I replaced said GtkButton with an GtkEventBox that behaves like a button but respects children with input.

Todo:

image

Testing:

notify-send 'Title' 'body' -A inline-reply=Text or https://tests.peter.sh/notification-generator/

Everything is done here, just need to make sure that it works as expected in Sway, https://github.com/swaywm/sway/pull/7587

tukusejssirs commented 1 year ago

@ErikReider, do I get it right that inline replies will work on Sway after swaywm/sway#7587 is merged? 🤔

ErikReider commented 1 year ago

@ErikReider, do I get it right that inline replies will work on Sway after swaywm/sway#7587 is merged? thinking

Will work now, but only in the control center. We check if the compositor supports the ON_DEMAND interactivity which is required to get keyboard focus on floating notifications which is added in that PR :)