ErikReider / SwayNotificationCenter

A simple GTK based notification daemon for SwayWM
GNU General Public License v3.0
1.15k stars 59 forks source link

backlight control for none intel_backlight devices / laptops #364

Closed JaKooLit closed 5 months ago

JaKooLit commented 5 months ago

Please read through the README and the Man pages before submitting Please also make sure that there isn't any prior issue describing this bug

Describe the bug Seems that the backlight is tied to intel_backlight.

To Reproduce Steps to reproduce the behavior: 1.) copied schema into same folder on ~/.config/swaync 2.) Edited config.json to schema: "$HOME$/.config/swaync/configSchema.json" 3.) Edited $HOME$/.config/swaync/configSchema.json backlight device to default: amdgpu_bl0 (since thats the one on my /sys/class/backlight 4.) swaync-client -R 5.) launch swaync on tty. got a warning. Could not find device /sys/class/backlight/intel_backlight/brightness

Expected behavior control of brightness since I dont have intel

Screenshots to follow

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

JaKooLit commented 5 months ago

Screenshot_02-Jan_13-11-09_5213

ErikReider commented 5 months ago

Don't edit the configSchema, copy the default config from /etc/xdg/swaync. The configSchema is only used to get JSON completion with supported editors

JaKooLit commented 5 months ago

so in other words its not fully supported..

got it.. thanks

ErikReider commented 5 months ago

so in other words its not fully supported..

What is not supported? Any backlight should be supported

JaKooLit commented 5 months ago

so in other words its not fully supported..

What is not supported? Any backlight should be supported

the default config.json from the /etc/xdg/swaync does not have buttons grid, volume, backlight.. etc... thats why I added in the copied config.json from /etc/xdg/swaync all the extras that I wanted.

but when I launch swaync through tty, I have got that message that cannot find intel_backlight, because I dont have intel backlight. That is why I thought about editing that configSchema.json to remove that intel_backlight and change with what backlight I have. which is amdgpu_bl0 but when I relaunch swaync, it is still looking for intel_backlight

ErikReider commented 5 months ago

Have you edited the backlight widget-config?

"widget-config": {
    "backlight": {
      "subsystem": "backlight",
      "device": "amdgpu_bl0"
    }
}
JaKooLit commented 5 months ago

Have you edited the backlight widget-config?

"widget-config": {
    "backlight": {
      "subsystem": "backlight",
      "device": "amdgpu_bl0"
    }
}

excellent..

Thanks for pointing that out. It works