ErikReider / SwayNotificationCenter

A simple GTK based notification daemon for SwayWM
GNU General Public License v3.0
1.15k stars 58 forks source link

[Bug] incorrect alignment in the panel with positionY=bottom #391

Closed kolalok closed 3 months ago

kolalok commented 4 months ago

With the config option positionY set to bottom, notifications align to the bottom of the notification panel, as expected. In previous version (0.9.0) there was a sufficient gap between the last notification and the bottom of the panel. However in 0.10.0 the last notification is partially positioned past the end of the window. It is not a critical problem, but it does not look well, when there's usually plenty of space above.

0.9.0: obrazek

0.10.0: obrazek

It behaves the same with or without Waybar running, and also with control-center-exclusive-zone turned off.

Steps to reproduce the behavior:

  1. Use default config files and only change positionY to bottom
  2. Send a notification
  3. Open the notification panel
  4. See the problem

swaync.log

OS, versions:

kellya commented 3 months ago

I just installed this today, and saw the same thing. I "fixed" it by adding a margin-bottom: 50px; to the style css in .control-center .control-center-list. So it looks like

.control-center .control-center-list {
  /* List of notifications */
  background: transparent;
  margin-bottom: 50px;
}

image

ErikReider commented 3 months ago

I just installed this today, and saw the same thing. I "fixed" it by adding a margin-bottom: 50px; to the style css in .control-center .control-center-list. So it looks like

.control-center .control-center-list {
  /* List of notifications */
  background: transparent;
  margin-bottom: 50px;
}

image

The pr fixes this without any needed CSS tweaks :)

kolalok commented 3 months ago

perfect! thank you