search

ErikReider / SwayOSD

A GTK based on screen display for keyboard shortcuts like caps-lock and volume
GNU General Public License v3.0
562 stars 35 forks source link

Fix bug related to blight and add a feature for brightness #67

Closed Albert24GG closed 5 months ago

Albert24GG commented 9 months ago

When using this program I noticed that when changing brightness quickly(ex: raise it two times and then lower it), the indicator(osd bar) would not reflect these changes(in case of the previous example it would raise when I lower the brightness). So I found out that the current brightness of the blight device does not update properly. Reloading the device current value solved this issue. Another problem I found is that there was no way to change the brightness by a custom delta anymore(this was possible before), so I added some code that checks if the argument is signed or not and applies the changes(if there's no sign, then that means the user wants to set the brightness to that value). LE: This PR fixes #68.

Albert24GG commented 7 months ago

@ErikReider Hey, did you have time to look over this PR? Is there any changes I have to make? Thanks!