ErikWittern / openapi-snippet

Generates code snippets for given Swagger / Open API documents
MIT License
115 stars 66 forks source link

While working on examples I noticed that arrays are not handled correctly by default #83

Closed michaelgwelch closed 2 years ago

michaelgwelch commented 2 years ago

As I work on making #82 more robust and after running the tests, I've observed that form arrays are not being handled properly. I'll add the links but the 3.0 specs says that if not specified then explode defaults to true for form parameters.

As part of #82, I will be trying to address form and simple style parameters for primitives, arrays, and objects and obeying the explode setting.

3 tests are passing that should be failing:

I have fixes for this as part of #82 which I'm still working on.

michaelgwelch commented 2 years ago

A simple fix for the test cases is to just explicitly set explode to false for each of these parameters. Then #86 adds support for exploding objects and arrays and tests all the different variations.

Fixed by #86