search

Eriku33 / Foundry-VTT-Image-Hover

Character art module for Foundry Virtual Table top
MIT License
7 stars 12 forks source link

I have fixed the incompatibility with 8.1, it is a one line change #14

Closed gcolgate closed 3 years ago

gcolgate commented 3 years ago

Change line 13 to let DEFAULT_TOKEN = ""; // Quick not good fix for DEFAULT_TOKEN no longer existing

I am currently stuck figuring out how to add a branch that can be cherry picked in github

gcolgate commented 3 years ago

https://github.com/gcolgate/Foundry-VTT-Image-Hover/commit/52711c53b8afefc332cde12d2d98165a3ca8ecb1 Here is the commit. I am not sure how to make it visible

amcvfx commented 3 years ago

I tried using the version you posted but I get this error:

image

Eriku33 commented 3 years ago

Hello everyone!

Sorry for the delay, just been enjoying life at the moment. Haven't used Foundry for a very long time. Newest release should solve some problems (1.1.8), let me know if I missed something.

gcolgate commented 3 years ago

That's the error message I fixed I hope you fixed it correctly! I just defined that missing symbol as ""

On Wed, Jun 9, 2021, 2:44 PM amcvfx @.***> wrote:

I tried using the version you posted but I get this error:

[image: image] https://user-images.githubusercontent.com/35099081/121433652-3525ef80-c974-11eb-9f87-c2a8cc05d185.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Eriku33/Foundry-VTT-Image-Hover/issues/14#issuecomment-858122833, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGSESXJDDF7ZYCWXXOPVJDTR7OD7ANCNFSM46FHKHTQ .

Eriku33 commented 3 years ago

Thanks gcolgate,

I appreciate how you've tried to help others, I've looked into it and fixed it.

Eriku33 commented 3 years ago

You will also need to install the keybind lib module (https://foundryvtt.com/packages/keybind-lib)

gcolgate commented 3 years ago

thanks

On Thu, Jun 10, 2021 at 3:36 PM Eriku33 @.***> wrote:

You will also need to install the keybind lib module ( https://foundryvtt.com/packages/keybind-lib)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Eriku33/Foundry-VTT-Image-Hover/issues/14#issuecomment-859127381, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGSESQR5NQPODAE2ZS3XW3TSE45BANCNFSM46FHKHTQ .