ErisApps
commented
3 years ago Furthermore, I think it would be a good idea to add the time dependence parameters and such to the README as well so users can actually be aware that this is a thing. Most of them don't go sniffling around in the code so yeah... Regardless all my remarks, thanks a lot for providing the integration of Time Dependence in HSV 😸
A couple of notes
Config property names use "timeDependency" instead of "timeDependence" prefix as that's what the old version used, so this supports legacy configs. If it bothers you, I'm happy to look into supporting both names or changing the code to match the "timeDependency" naming scheme (though I prefer timeDependence 😛 )
There's some code redundancy added here as time dependence judgments are only slightly different from the previous judgments (float instead of int). I don't know C# very well, so I couldn't figure out how to get this done via a template/generic instead 😔. An alternative might be to have both of these implement an interface or abstract class instead? Again, not too familiar with C#.
I'm happy to write the necessary parts of the README for this, if you even want to include it there seeing as most users won't even know what TD is.