search

ErisApps / HitScoreVisualizer

Beat Saber plugin that colors the scores that pop up when you hit notes
MIT License
72 stars 13 forks source link

Arcs leading into a chain head make HSV think the chain head has post-swing score #27

Closed 1unar-Eclipse closed 2 days ago

1unar-Eclipse commented 3 days ago

(I'm using release 3.4.0. I have not tested this on 3.4.3 because modding as a whole is unstable for me on the latest Beat Saber release.)

If a map has an arc that ends with a chain head, the mod will seemingly treat the chain head as a normal note, calculating and using the post-swing value even though it should always be 0 in vanilla. Active gameplay and BeatLeader replays both have this effect.

Example config that has incorrect scores in red To verify, https://beatsaver.com/maps/3bcb2 at 0:57 is an example that has an arc leading into a chain.

qqrz997 commented 2 days ago

this is an issue with the game, those notes actually do give up to 115 points, you could even unselect a config and still see they do. ost maps don't use arcs into chains so it's probably not intended behaviour but to be honest this doesn't break anything and the arcs are just giving free score.

qqrz997 commented 2 days ago

(p.s. as you mentioned it, the latest version is not technically supported for modding quite yet, but you technically could scrounge around github for all of the core mods)