Closed incertia closed 2 years ago
Just noticed that you had created this PR. I'll try to check it fully sometime this weekend when all mods are fully updated again.
As for your suggestion to change the order, that would be a breaking change technically so I rather not right now. That being said, I'll keep it in mind when bigger changes are required in that part of the config 😸
Anyways, thanks a lot for the contribution.
merged master
back into this branch
any updates on this?
Sorry, had a lot of things going on so haven't had the time just yet to check it out. I'll try to give this PR a look before I release a new version for 1.17.0
Did some really minor adjustments, marking the first argument of the FormatTimeDependenceSegment
method as nullable. and replacing an hardcoded empty string literal with string.Empty
.
Other than that, it looks just fine. Thank you very much for this contribution (and my sincere apologies for making you wait for almost 2 months)
New version will be released one of the upcoming days, has to go through some more testing first as quite a few things have changed.
support %t in TD judgement section so we can avoid looping through 70-80 useless judgements (on average) per hit and simplify the TD judgement section. e.g.
maybe also consider doing TD from bottom up instead of top down since lower is better tm.