ErisApps / HitScoreVisualizer

Beat Saber plugin that colors the scores that pop up when you hit notes
MIT License
71 stars 13 forks source link

format td judgements #8

Closed incertia closed 2 years ago

incertia commented 3 years ago

support %t in TD judgement section so we can avoid looping through 70-80 useless judgements (on average) per hit and simplify the TD judgement section. e.g.

  "timeDependencyDecimalPrecision": 0,
  "timeDependencyDecimalOffset": 2,
  "timeDependencyJudgments": [
    {
      "threshold": 0.31,
      "text": "<color=#FF0000>%t</color>"
    },
    {
      "threshold": 0.21,
      "text": "<color=#FFFF00>%t</color>"
    },
    {
      "threshold": 0.11,
      "text": "<color=#00FF7F>%t</color>"
    },
    {
      "threshold": 0.06,
      "text": "<color=#2D9DAD>%t</color>"
    },
    {
      "threshold": 0,
      "text": "<color=#FFFFFF>%t</color>"
    }

maybe also consider doing TD from bottom up instead of top down since lower is better tm.

ErisApps commented 3 years ago

Just noticed that you had created this PR. I'll try to check it fully sometime this weekend when all mods are fully updated again.

As for your suggestion to change the order, that would be a breaking change technically so I rather not right now. That being said, I'll keep it in mind when bigger changes are required in that part of the config 😸

Anyways, thanks a lot for the contribution.

incertia commented 3 years ago

merged master back into this branch

incertia commented 2 years ago

any updates on this?

ErisApps commented 2 years ago

Sorry, had a lot of things going on so haven't had the time just yet to check it out. I'll try to give this PR a look before I release a new version for 1.17.0

ErisApps commented 2 years ago

Did some really minor adjustments, marking the first argument of the FormatTimeDependenceSegment method as nullable. and replacing an hardcoded empty string literal with string.Empty.

Other than that, it looks just fine. Thank you very much for this contribution (and my sincere apologies for making you wait for almost 2 months)

ErisApps commented 2 years ago

New version will be released one of the upcoming days, has to go through some more testing first as quite a few things have changed.