Gridcoin blocks created by a pre-mandatory + pre-v8 version (3.6.0.1)?

Erkan-Yilmaz commented 6 years ago

In the last 100 blocks we had 2 blocks created by these version identifiers:

ClientVersion: 3.6.0.1-unk / version: 8
- block 1057518 (oct 22, 08:35:44), by user: nounam
ClientVersion: 3.5.9.0a-553-g2e58af1 / version: 8
- see also closed bug for more info
- block 1057576, by user: FredericChopin

But the current mandatory is 3.6.0.2 (released on 2017 August 26)

Erkan-Yilmaz commented 6 years ago

see also comment by @tomasbrod from above link:

"There is a check that prevents blocks with less version from entering, but the check for versionstring was removed (not helpful + caused problems). The script that detects git version and puts it into versionstring probably did not work (missing tags?), I already have an idea on how to improve it."

tomasbrod commented 6 years ago

The mandatory version was 3.6.0.1. So user nounam is ok. Versionstring 3.5.9.0a-553-g2e58af1 has git commit hash in it, 2e58af1 is the latest leisure release.

tomasbrod commented 6 years ago

Sorry. Apparently 3.6.0.2 was mandatory too. Let me explain. 3.6.0.1 had all the necessary things for v8, but the height at which first v8 block were accepted was erroneously set to 1010001 while the same version would begin creating v8 blocks at height 1010000. V8 was formally scheduled for 1010000. There were two alternatives to fix this. Either we change accept block to 10100000, which would require all exchanges and whales who already updated to .1 release to update again. Or move the miner block and the start of V8 one block up. The later change was released as 3.6.0.2. The only downside was that 3.6.0.1 nodes were not able to stake block 1010000.

Now after I wasted this much time with writing this, @Erkan-Yilmaz please include it into your next post. Thanks.

Erkan-Yilmaz / GRC

Gridcoin blocks created by a pre-mandatory + pre-v8 version (3.6.0.1)? #50