search

Erkan-Yilmaz / Gridcoin-tasks

tasks, wishes, ideas, ... for the Gridcoin project
26 stars 1 forks source link

privacy mode: wallet shouldn't show the user's sensitive data (balance, ...) #58

Open Erkan-Yilmaz opened 7 years ago

Erkan-Yilmaz commented 7 years ago

privacy screen:

@Peppernrino can you detail a little more ? thx

mentioned in hangout 4: 1:01:19

grctest commented 7 years ago

I believe that the idea was that if the wallet is locked, the wallet 'dashboard' shouldn't show off the user's full balance (sensitive data).

Peppernrino commented 7 years ago

indeed. an unlock screen, before the wallet appears.

maybe an option to change for staking or not in the wallet instead of the lock, so the choice for voting etc is still available.

startailcoon commented 7 years ago

Since cryptocurrency like Gridcoin bases on Bitcoin, that are a public ledger, this "sensitive" data will always be visible. I can understand the users concern with it being displayed on the local computer. But I think that instead of making Rob, or any other developer, put time in to making a system to be able to lock the wallet further the user should use the systems built in locking feature when they are not at the computer.

grctest commented 7 years ago

The user should use the systems built in locking feature when they are not at the computer.

I concur, if you're leaving your computer unlocked when you're AFK you've got bigger problems than hiding your balance. We can all see each others full balances via gridcoinstats.eu

Tell any nosy people to quit shoulder surfing, if you're in public don't take your entire balance with you.

Peppernrino commented 7 years ago

they can't all be zingers. :)

startailcoon commented 7 years ago

I see two options for this, if someone wishes to implement it some day

  1. Nothing is visible as long as the wallet is locked. Transactions history, staking details etc. are not rendered as long as the wallet is not unlocked. You have to set the wallet to "staking only" or "fully opened" to display the data. This poses a dilemma for those who do not want this. But is easy to implement with just a few changes to the code.

  2. Build a fourth option to locked, staking only and fully open. It would be an option before "locked", something like "privacy mode". This in itself could have "staking only" as an option and still not show the data. This would require extensive work of coding, hence the reason of my previous comment.

Making an option like this is still a bad idea in my opinion. Users that are unfamiliar with cryptocurrency might mistake it with a security compared to a bank account where none can see the status or holdings of the account. This would only be a local precaution and imho totally unnecessary.

Peppernrino commented 7 years ago

i could see solution 2 interfering with the existing code more than hiding the information as suggested in solution 1. why wouldn't anybody want the information hidden? not trying to poke holes in it... just i can't think of a situation where hiding the information would be detrimental. Even though the information is public, it doesn't have to be blatant. i honestly think anybody confused about the status of their balance will seek support in IRC or on one of the many forums we now populate.

pwnorbitals commented 7 years ago

I think it would be a good idea showing an "unlock" screen and hiding balance, CPID etc... Showing network status could still be okay though. Option 1 looks good