search

ErlyORM / boss_db

BossDB: a sharded, caching, pooling, evented ORM for Erlang
Other
277 stars 138 forks source link

Do not react to normal exits #180

Closed burbas closed 10 years ago

burbas commented 10 years ago

Solves the problem with leaking connections for MongoDB (issue: #178). Do not know if this creates problems for other adapters though.

choptastic commented 10 years ago

This does look good, but as you note, such a simple task could lead to problems. My focus is boss_db this month, and I'll do some considering. But on first glance, this seems completely reasonable.

-Jesse

On Wed, May 21, 2014 at 3:47 AM, Niclas Axelsson notifications@github.com wrote:

Solves the problem with leaking connections for MongoDB (issue: #178 https://github.com/ChicagoBoss/boss_db/issues/178). Do not know if this

creates problems for other adapters though.

You can merge this Pull Request by running

git pull https://github.com/burbas/boss_db master

Or view, comment on, or merge it at:

https://github.com/ChicagoBoss/boss_db/pull/180 Commit Summary

  • Do not react to normal exits

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/ChicagoBoss/boss_db/pull/180.

Jesse Gumm Owner, Sigma Star Systems 414.940.4866 || sigma-star.com || @jessegumm

davidw commented 10 years ago

@choptastic did you look at how this interacts with other drivers at all?

choptastic commented 10 years ago

Hey David,

I haven't explored how it interacts with the other drivers, but I added a mongo-specific check for it, as I'm assuming (might be wrong) that normal exits by the other servers shouldn't be treated the same. So I have a fix for it, and got distracted by tests before pushing to mainline.

I'm going to push it now, and worry about the tests later.

On Wed, Jun 25, 2014 at 2:32 PM, David N. Welton notifications@github.com wrote:

@choptastic https://github.com/choptastic did you look at how this interacts with other drivers at all?

— Reply to this email directly or view it on GitHub https://github.com/ChicagoBoss/boss_db/pull/180#issuecomment-47147714.

Jesse Gumm Owner, Sigma Star Systems 414.940.4866 || sigma-star.com || @jessegumm

choptastic commented 10 years ago

Here's the relevant commit: https://github.com/ChicagoBoss/boss_db/commit/bdff76ee690be22ae15bcec128b0979a1113fb10