search

ErlyORM / boss_db

BossDB: a sharded, caching, pooling, evented ORM for Erlang
Other
277 stars 138 forks source link

Added an ssl Option in pgsql adapter #183

Closed omarayad1 closed 9 years ago

omarayad1 commented 10 years ago

Added an ssl Option in pgsql adapter, you can now connect to the Postgresql Database with ssl enabled

davidw commented 10 years ago

I merged this in my branch and fixed a few things. It should be ready to import in the main branch.

choptastic commented 10 years ago

Fantastic. I'll give it a gander this week.

On Tue, Jun 3, 2014 at 4:18 AM, David N. Welton notifications@github.com wrote:

I merged this in my branch and fixed a few things. It should be ready to import in the main branch.

— Reply to this email directly or view it on GitHub https://github.com/ChicagoBoss/boss_db/pull/183#issuecomment-44941725.

Jesse Gumm Owner, Sigma Star Systems 414.940.4866 || sigma-star.com || @jessegumm

drobakowski commented 9 years ago

Any chance that this gets tweaked and merged anytime soon? @omarayad1 in your if statement the default match is missing and will therefore fail in other cases than true. I've already tweaked this, included the 'required' option from the underlying PostgreSQL pgsql/epgsql library and updated the README on a separate branch with the commit c774de6. You can use it for tweaking your PR or alternatively I could create a new PR with my changes, whatever is faster to get this merged.

danikp commented 9 years ago

@drobakowski , it will be better if you create new PR

danikp commented 9 years ago

merged in #234