ErnWong / crystalorb

Network-agnostic, high-level game networking library for client-side prediction and server reconciliation (unconditional rollback).
https://ernestwong.nz/crystalorb/demo
Other
218 stars 13 forks source link

Update to bevy 0.7 #27

Open ErnWong opened 2 years ago

ErnWong commented 2 years ago

Fixes #26

Remaining tasks: Add an in-tree example that uses crystalorb-bevy-networking-turbulence crate to test that it still works.

codecov-commenter commented 2 years ago

Codecov Report

Merging #27 (4b5a54d) into master (b49cf55) will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   77.53%   77.51%   -0.03%     
==========================================
  Files          15       15              
  Lines         837      836       -1     
==========================================
- Hits          649      648       -1     
  Misses        188      188              
Impacted Files Coverage Δ
src/clocksync.rs 85.48% <0.00%> (-0.24%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b49cf55...4b5a54d. Read the comment docs.

ErnWong commented 2 years ago

Also todo: upgrade wasm bindgen version to fix clippy errors with the demo. Making it part of this pr as it seems like it makes sense to bundle with the rust edition upgrade.

ErnWong commented 2 years ago

Tested using https://github.com/vilcans/orbgame and it seems to work.

Since we are looking to replace our bevy plugin with one that has better bevy integration (#14), I probably won't add a playable bevy example for crystalorb-bevy-networking-turbulence into this repo. (There's already a short compilable example in that crate's readme, but that's not technically playable).

Once the next version of CrystalOrb gets released with this changes, I might make a PR for orbgame with those changes I used to test this PR.

ErnWong commented 2 years ago

Oh rip, I'm too slow. Bevy 0.7 is already out. https://bevyengine.org/news/bevy-0-7/

Shatur commented 2 years ago

BTW, https://github.com/smokku/bevy_networking_turbulence is unmaintained. I would suggest to consider using https://github.com/lucaspoffo/renet instead.