scan for pom's in folder and subfolders and auto register

ErnestOrt / Trampoline

Admin Spring Boot Locally

http://ernestort.github.io/Trampoline/

Apache License 2.0

356 stars 81 forks source link

scan for pom's in folder and subfolders and auto register #1

Open cforce opened 7 years ago

cforce commented 7 years ago

With about 100 microservices you get a tough time to register them all manually ;) Ms uses server port as configured in application.yml.

ErnestOrt commented 7 years ago

Hi cforce,

It would be great to be able to provide a directory and autoregister every Ms in there.

I will write it down as an improvement.

Btw, If you have time and you want, you can implement it and, once done, create a pull request. It will e great ;)

Enjoy your weekend!

cforce commented 7 years ago

I really would if we have high demand, it will push if we do. Currently the feature is embedded in Spring Cloud Tools Boot Dashboard we already use on development side. Currently I won't have time but anyway I think your contribution will spread a lot more with that enhancement.

ErnestOrt commented 7 years ago

Sure, I completely agree with you. Thanks for sharing your ideas! I will implement as soon as I can.

siddhant0509 commented 7 years ago

Seems like a good feature to have. If not yet implemented, i can pick it up.

ErnestOrt commented 7 years ago

Sure @siddhant0509. All yours. Make a fork and create a PR to be able to review it. Thanks for your effort!!

cforce commented 7 years ago

Great .. big step forward ;)

mouradsm commented 6 years ago

Hi, I'm planning to implement this feature. @ErnestOrt have any idea about how to start?

ErnestOrt commented 6 years ago

Hi @mouradsm ,

This is a quite challenging task.

If I where you, I would do the following:

require user to set a folder.
loop inside this folder to get all pom files
for each pom (or build file in case using gradle): 3.1 get basic info as name 3.2 get application properties (if exist to get actuator endoint or server port) 3.3 somehow you should need to get git folder as well if exists
A final table should be shown to the user to confirm all information collected

As usual, adviceing is easier than coding, so take your time mate!

We can do code reviews on each milestone so no worries for that, first make it work, second leave it clean!

Good luck and thanks for you time!

albertoaflores commented 5 years ago

Not sure the status of this, however I also found an issue (somewhat related) where if I include the pom.xml file in the location of the "FileSystem" deployment, Trampoline will include the pom.xml and try to "cd" into it (e.g. ~/Documents/). Upon failure (since it can "cd" into a file, it will use the same "trampoline" location and start another trampoline instance. Would you prefer this handle here (in this issue) or enter it as a bug. Happy to contribute as well.

Nice work here!

ErnestOrt commented 5 years ago

Hi @albertoaflores,

First of all, thanks for your time and feedback!!

Probably, it would be better to handle it under other issue.

Feel free to start a discussion about a solution and/or open PR!

Have a nice Sunday!! 😉😉