Add endpoint for gracefully shutting Trampoline down

ErnestOrt / Trampoline

Admin Spring Boot Locally

http://ernestort.github.io/Trampoline/

Apache License 2.0

356 stars 82 forks source link

Add endpoint for gracefully shutting Trampoline down #38

Closed jtwalraven closed 6 years ago

jtwalraven commented 6 years ago

It would be great to have a way to shut Trampoline down from inside of the application just as you would other instances. @ErnestOrt I am curious for your thoughts on this. Do you think we could treat Trampoline as a microservice within the instance list, or do you think it would be better to make a separate shutdown endpoint?

ErnestOrt commented 6 years ago

Sounds good @JTWalraven ! At the end, this project aims to reduce time spent in front of a terminal and you have to go there to stop it :))

PR #41

I create this Pull Request so if you were imagining some better implementation speak up, otherwise I am going to close it,

While doing it, I was wondering if it would be necessary to stop all started ms or even if it would be better to have a "hard or soft shutdown":

Hard: stop Trampoline + ms
Soft: stop only Trampoline

What do you think?

jtwalraven commented 6 years ago

I am checking it out now.

jtwalraven commented 6 years ago

I think it would be better to have a soft shutdown. That would keep a more loosely coupled architecture and make Trampoline treated similarly to the other microservices.

Maybe we could open an issue for discussing a method of quickly shutting all instances down?

ErnestOrt commented 6 years ago

Sure! Let's do that.