Switched to using process builder API

ErnestOrt / Trampoline

Admin Spring Boot Locally

http://ernestort.github.io/Trampoline/

Apache License 2.0

356 stars 81 forks source link

Switched to using process builder API #49

Closed jtwalraven closed 6 years ago

jtwalraven commented 6 years ago

@ErnestOrt This is a major change, so I think it would be appropriate if you could double check it works correctly for you. Could you please review the PR and test that it works on Linux (Unix) and Windows?

Closes #37

ErnestOrt commented 6 years ago

@JTWalraven Great job! Could you double check what's going on with Maven-Windows? Meanwhile I'm testing Linux (I will have to set up a VM).

jtwalraven commented 6 years ago

Thanks @ErnestOrt! I will have to set up my Windows VM :laughing:

ErnestOrt commented 6 years ago

@JTWalraven, after testing on UNIX I realized Gradle-Unix doesn't work :(

Since the current solution works, at this point we can decide which of these 2 things are more convenient for us:

Leave the java-process-api branch for the future and pick up another task.
Go for it an solve it, make it work on UNIX/Windows for Maven/Gradle.

Again, your work is really appreciate so don't feel bad if you pick up the first option.... We are here to spend good time and enjoy with it not to put unnecessary pressure in our lifes.

jtwalraven commented 6 years ago

Hmm, that is strange. It definitely worked for me when I tried it last night. I would still like to solve it, but it may be a while because I will be busy this upcoming week. I will close out this PR and open a new one when I have finished. Thanks @ErnestOrt !

ErnestOrt commented 6 years ago

@JTWalraven just to let you know, I was testing with examples provided on the repo: ms-example-gradle, ms-example-maven. Have a nice week!