fixed git clone error - Githubissues

ErnestOrt / Trampoline

Admin Spring Boot Locally

http://ernestort.github.io/Trampoline/

Apache License 2.0

356 stars 82 forks source link

fixed git clone error #59

Closed Ravis22 closed 6 years ago

Ravis22 commented 6 years ago

There was an error in git manager when issuing a command for git clone. It was initiating the clone command immediately after setting the credentials. However this should be done after credentials are set.

ErnestOrt commented 6 years ago

Hi @Ravis22 !

Thanks for this PR.

Don't you think you wanted to remove call() from line 96 instead of in line 44 from GitManager.java?

Cheers

Ravis22 commented 6 years ago

Ah! yes while doing local testing I modified line 96 but somehow before push mistakenly I updated line#44. Applied correct fix now. Kindly approve

ErnestOrt commented 6 years ago

Great @Ravis22! In this case, you will need to set back .call() on line 44.

After it, I will merge it :)

Cheers!

ErnestOrt commented 6 years ago

Solved