ErnestOrt / Trampoline

Admin Spring Boot Locally
http://ernestort.github.io/Trampoline/
Apache License 2.0
356 stars 82 forks source link

Typo in shutdown endpoint enabling #69

Closed charm911 closed 6 years ago

charm911 commented 6 years ago

In the ScriptContentsProvider class, there is a typo to the "-D" shutdown endpoint.

It should be endpoint.shutdown.enabled ... not "endpointS".

This prevents the shutdown from happening if the provided microservice does not itself enable it (as it is disabled by default).

ref: https://docs.spring.io/spring-boot/docs/current/reference/html/production-ready-endpoints.html#production-ready-endpoints-enabling-endpoints

ErnestOrt commented 6 years ago

Good point!

We will fix it as soon as possible.

Thanks for your feedback!

Cheers!

ErnestOrt commented 6 years ago

@charm911

Just to clarify

endpoints.shutdown.enabled=true

This is a deprected endpoint included just to avoid old version issues.

http://www.baeldung.com/spring-boot-shutdown

This is the current one:

management.endpoint.shutdown.enabled=true

https://docs.spring.io/spring-boot/docs/current/reference/html/common-application-properties.html

Closing since it's not a bug.

Have a nice week!