search

Ernst79 / bleparser

Parser for passive BLE advertisements
MIT License
29 stars 16 forks source link

Missing requirement Cryptodome? #11

Closed freol35241 closed 3 years ago

freol35241 commented 3 years ago

When installing this package from pypi (pip install bleparser) the Cryptodome package does not get installed, which seems to be a hard requirement (https://github.com/Ernst79/bleparser/blob/master/package/bleparser/xiaomi.py#L5).

Should be added into setup.cfg under "install_requires".

I would be happy to draft a PR for this, but a little unsure about the requirements_test.txt in this repo which specifies a specific version of Cryptodome. Any particular reason for pinning the version or would any version >3 be ok?

Ernst79 commented 3 years ago

I was under the impression that packages = find: would take care of that, but apparently not.

Any version of Cryptodome is ok, using the latest would be preferred, I think.