search

Err0neus / Santos-Discography-Analyser

Jupyter Notebook based interface to download and visualise music artists discography data, statistics and lyrics sentiment
8 stars 1 forks source link

loop/freeze? #60

Closed Err0neus closed 3 years ago

Err0neus commented 3 years ago

Santos freezes getting lyrics for David Bowie :(

Freezes at 17% with the following album selection:

YEAR_ALBUM EXCLUDE_ALBUM [1967] David Bowie FALSE [1969] David Bowie FALSE [1970] The Man Who Sold The World FALSE [1971] Hunky Dory FALSE [1972] The Rise And Fall Of Ziggy Stardust And The Spiders From Mars FALSE [1973] Aladdin Sane FALSE [1973] Pinups FALSE [1974] David Live TRUE [1974] Diamond Dogs FALSE [1975] Young Americans FALSE [1976] Station To Station FALSE [1977] "Heroes" FALSE [1977] Low FALSE [1978] Stage FALSE [1979] Lodger FALSE [1980] Scary Monsters FALSE [1983] Let's Dance FALSE [1983] Ziggy Stardust - The Motion Picture FALSE [1984] Tonight FALSE [1987] Glass Spider Concert Special - Olympic Stadium (Montreal, Canada) Aug 30, 1987 TRUE [1987] Never Let Me Down FALSE [1993] Black Tie White Noise FALSE [1993] The Buddha Of Suburbia FALSE [1994] Live Santa Monica '72 TRUE [1995] 1. Outside (The Nathan Adler Diaries: A Hyper Cycle) FALSE [1997] Earthling FALSE [1999] Hours... FALSE [2000] Bowie At The Beeb TRUE [2000] Liveandwell.com TRUE [2002] Heathen FALSE [2003] Reality FALSE [2009] VH1 Storytellers TRUE [2013] The Next Day FALSE [2016] ★ (Blackstar) FALSE [2017] Cracked Actor (Live Los Angeles '74) TRUE [2017] Live Nassau Coliseum '76 TRUE [2018] Glastonbury 2000 TRUE [2018] Welcome To The Blackout (Live London '78) TRUE [2020] Changesnowbowie TRUE [2020] No Trendy Réchauffé (Live Birmingham 95) TRUE [2020] Ouvrez Le Chien [Live Dallas 95] TRUE [2021] At The Kit Kat Klub (Live New York 99) TRUE [2021] Look At The Moon! (Live Phoenix Festival 97) TRUE [2021] Something In The Air (Live Paris 99) TRUE

Err0neus commented 3 years ago

confirmed infinite loop in GET_LYRICS.PY

caused by songs with a page, but no lyrics (e.g. https://genius.com/David-bowie-a-lad-in-vain-aka-zion-lyrics) added condition (get_list_of_tag(page) != []) before goint to the WHILE loop to fix it

Err0neus commented 3 years ago

the fix seems to have caused another issue ... see #61 need to change. exploring alternative with a simple counter and break

Err0neus commented 3 years ago

seems back to normal, and infinite loop is prevented.