Open DavidTheExplorer opened 8 months ago
I appreciate that you understood :)
1 : You need to add okhttp dependency since this time the jar is distributed locally as .jar file which don't include okhttp
libs
2 : The reason the library is distributed manually is bcz, at that time, the jitpack was not working (see this and this) now it is working back again.
PS : The further release will be on jitpack.
I appreciate that you understood :)
I hope it was clear that I had nothing against you :)
1 : You need to add okhttp dependency since this time the jar is distributed locally as .jar file which don't include
okhttp
libs
I still don't understand the problem with creating a "fat" jar that includes the dependencies, which is how libraries are usually published.. Is that due to the fat jar's size?
_PS : The further release will be on jitpack.
Awesome! Can you please keep this on open and notify this issue once it's on jitpack?
Yeah, the reason that I did not create a fat jar
is mainly because of size. One more reason not to do so is that it is generally good practice to give the user your library without transitive dependencies so he/she has full control over it.
Also, mostly developers will be using this library to create a client or API, which will already most probably include the okhttp
dependencies. So re-including it in the .jar will be waste of space.
After I got an official response from
Instagram4J
's creator, I decided to migrate my project to use this library. However, I have a few questions before I even write the first line of code:Why do I also need to add the
OkHttp
dependency - why isn't it included in the artifact?I read the README and I'm not sure which outages you're talking about, Jitpack works great and I use it in all of my projects - I highly recommend posting Jitpack dependencies.