search

ErrorxCode / JxInsta

An object-oriented reverse engineered instagram web API made in Java. Now build bots, scrap data, create instagram apps, and a lot more in your favourite language
Apache License 2.0
20 stars 5 forks source link

Use GitHub packages #6

Closed ncovercash closed 1 month ago

ncovercash commented 7 months ago

This PR does a few things:

Add a GitHub workflow

This allows PRs/commits to automatically be checked for compilation, as well as deployment to GitHub packages whenever a new release is created.

Use GitHub packages for deployment

This fixes #4 since we would no longer rely on Jitpack. Instead, this adds a "Packages" section to the main repository page (as seen on my fork):

image

This can be configured to provide snapshot/tip-of-main releases, but I'm not sure what version management (if any) is here, so that can come later. As of now, this will publish a package on release using the version in build.gradle (again, not sure if that should go elsewhere, but this is a starting point).

One caveat for this is that GH expects lowercase artifacts IDs, and the deployment will fail otherwise, hence the use of jx-insta there.

Change the group name

Not sure what Libraries was, but I imagine you want this to look like EasyInsta.JxInsta instead, so I changed the root project name in settings.gradle. Also, not sure what a number of those dependencies are, or if they were carried over from some other project or something?

ErrorxCode commented 7 months ago

I appreciate your contribution and fix for that problem. Unfortunately, packages published on Github Packages require authentication to be used by the build automation tools. Hence, it is not recommended for public libraries.

See this discussion and this answer

Thanks for your hard work and time, anyway :)

ncovercash commented 7 months ago

Ah, I'm used to using GH packages for docker images, which does not require authentication. It might not be a bad idea to keep the CI build step at least, though.

ErrorxCode commented 7 months ago

Alright! change your PR and commits to set-it only for for CI however, for distributing the library, we will use jitpack

Pro tip : You can also automate the publishing/building of the library on jitpack using Github Actions. So that on every release, the new version will be automatically build on jitpack :)

PS : If you are interested, I can provide you with more hints and guidance on how to do that

ErrorxCode commented 1 month ago

Inactive for 6 months