search

Erudika / para

Multitenant backend server for building web and mobile apps rapidly. The backend for busy developers. (self-hosted or hosted)
https://paraio.org
Apache License 2.0
531 stars 146 forks source link

support for ldap servers requiring authentication for read access #259

Closed mljohns89 closed 7 months ago

mljohns89 commented 7 months ago

Have you read the docs first? Yes OK, describe you changes: One line changer to cause Spring Security to trigger required config generation for LDAP Servers that require authentication.

Per Spring Docs, calling this method is required when implementations are outside of the Spring Context (which LDAPAuthenticator is): https://github.com/spring-projects/spring-ldap/blob/main/core/src/main/java/org/springframework/ldap/core/support/AbstractContextSource.java#L60-L62

Method call for reference: https://github.com/spring-projects/spring-ldap/blob/main/core/src/main/java/org/springframework/ldap/core/support/AbstractContextSource.java#L409

Tests? Didn't add any since it's a one liner and would require a lot of setup for an in-memory secure ldap server

albogdano commented 7 months ago

Thank you very much for the PR, Michael! I was unaware of that method. :+1: I will publish a new version soon. Right now, I'm in the process of migrating Para to Spring 3.x.

mljohns89 commented 7 months ago

@albogdano Thanks so much. Do you have rough a time frame by any chance?

albogdano commented 7 months ago

@mljohns89 I just released 1.49.4 containing your PR because the migration to Spring 3.x is taking a bit longer than I anticipated.

mljohns89 commented 7 months ago

@albogdano Awesome! Thanks so much!