search

Erudika / para

Multitenant backend server for building web and mobile apps rapidly. The backend for busy developers. (self-hosted or hosted)
https://paraio.org
Apache License 2.0
531 stars 146 forks source link

use afterPropertiesSet to initialize authenticationSource #266

Closed mljohns89 closed 7 months ago

mljohns89 commented 7 months ago

Have you read the docs first?

OK, describe you changes: @albogdano 1000 apologies.

When you call contextSource.afterPropertiesSet(), it will not have any affect unless the contextSource.authenticationSource is null. I've removed the line that initializes the authenticationSource to the empty SpringSecurityAuthenticationSource()

Tests? Tested this via debugging and set the authenticationSource to null manually. LDAP Login worked correctly

albogdano commented 7 months ago

Right, so apparently setting authenticationSource to SpringSecurityAuthenticationSource is not really needed, since there won't be any credentials initially stored in the security context.

albogdano commented 7 months ago

Thanks again, Michael! Please update Para to 1.49.5, which was just published.

mljohns89 commented 7 months ago

Yup exactly

On Mon, Apr 8, 2024, 4:39 AM Alex Bogdanovski @.***> wrote:

Right, so apparently setting authenticationSource to SpringSecurityAuthenticationSource is not really needed, since there won't be any credentials initially stored in the security context.

— Reply to this email directly, view it on GitHub https://github.com/Erudika/para/pull/266#issuecomment-2042184200, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABO5DKG4OCNHBH3BPDEKX73Y4JJUJAVCNFSM6AAAAABF3SGMBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBSGE4DIMRQGA . You are receiving this because you authored the thread.Message ID: @.***>