search

ErwinKomen / RU-lilac

0 stars 0 forks source link

August list of small things #32

Closed ErwinKomen closed 1 year ago

ErwinKomen commented 2 years ago

Double checking list of small things shown in the August 26 screenshot PDF

ErwinKomen commented 2 years ago

Pages 1-2

already dealt with

Canwit details

That is page 3

  1. Show the right Austat LiLaC code in the top-left title addition - okay
  2. Show the right Austat LiLaC code in the Austat summary, bottom - okay
    1. This is via sermon_superlinks.html
    2. This again makes use of Austat get_view()
    3. Okay, corrected get_view()
  3. Remove Lectio: - okay
  4. The field Fons materialis should also have a 'note' field to add things like 'fragment' or 'excerpt' - done
    1. There already is a note field to CanwitAustat
    2. Added view CanwitAustatDetails to show and edit them - done
      1. Right now the link to this field is on the note output itself...
      2. I changed that: if there is no note, then a button to show the CanwitAustat link is shown. If there is a note, then this note itself provides the link to the CanwitAustat details. - done
      3. Should change the CanwitAustatList (in breadcrumbs) to something else. Preferably the Canwit details - done
ErwinKomen commented 2 years ago

Authoritative statement details

That is page 4 of the PDF

  1. The information about Date and Genre(s) could /should be copied directly from Auwork - done
    1. Perform adaptations to transform the current Date/Genre to Auwork
    2. Adapt the Austat methods to show the value of Auwork:
      1. get_genres_markdown()
      2. get_date() (was: instance.date)
  2. Add fields:
    1. Opus - take this over (view only) from `Auwork). Ah, this is already there!
    2. CPL (signature). - done now. See below
      1. Should be under Auwork (authoritative work)
    3. Clavis (signature). - done now. See below
      1. Should be under CollWit (collection witness)
ErwinKomen commented 2 years ago

Email (31/oct/2022):

... dus laten we de Clavis code daarom maar aan een CollWit hangen. De CPL hoort bij WORK.

ErwinKomen commented 2 years ago

Storing of Clavis and CPL

  1. Both items are basically stored in the model Signature, which is like in Passim, containing fields code and editype - done
    1. The values for editype in LiLaC are: cpl, cla, oth (CPL, Clavis, other)
  2. The links between Auwork - Signature and Colwit - Signature are stored in separate tables: - done
    1. AuworkSignature with FK fields auwork and signature
    2. ColwitSignature with FK fields colwit and signature

Editing and viewing of Clavis and CPL

This concerns the Clavis and the CPL as they belong to either Auwork or Colwit...

  1. Auwork
    1. Added 'signatures' to view AuworkEdit
      1. Also added field siglist to AuworkForm
      2. And needed to add processing of one Signature via formset_objects
      3. Added processing in after_save() to make sure siglist changes are processed
    2. Added function get_signatures() to model Auwork
    3. Question: should Auwork signatures be more restricted to CPL ???
  2. Colwit
    1. Added 'signatures' to view ColwitEdit
      1. Also added field siglist to ColwitForm
      2. And needed to add processing of one Signature via formset_objects
      3. Added processing in after_save() to make sure siglist changes are processed
    2. Added function get_signatures() to model Colwit
    3. Question: should Colwitsignatures be more restricted to Clavis ???
ErwinKomen commented 2 years ago

Follow-up points

There are a few points to take into account as follow up from the above:

  1. Importing Colwit from Excel should correctly add the signatures - see #33
  2. Importing Auwork from Excel should correctly add the signatures - see #34

Questions

  1. Should the Colwit signatures also be shown in: Canwit and perhaps even in Austat ??
  2. Should the Auwork signatures also be shown in Austat ??
  3. Should the signatures be shown in any of the listviews?

Response

Here is the response:

  1. CPL en Clavis codes graag in Auwork (dat is genoeg; Austat verwijst naar Auwork)
  2. Clavis codes ook graag in Colwit en Canwit (omdat de Clavis database niet goed onderscheid maakt in Auworks en Colwits).

Conclusion:

  1. The signatures (defined and) shown in Auwork do not, apparently, need to be 'shown' in Austat
  2. The Clavis codes are defined in Colwit, and, apparently, they also need to show up (i.e. view-only) in Canwit
ErwinKomen commented 1 year ago

Implementation

  1. Make sure the signatures (CPL/Clavis) show up in the ColWit listview
    1. Add siglist to the model of Colwit
    2. Add code to calculate siglist:
      1. One-time via adaptations.py
      2. When a signature is added to a colwit
      3. When a signature is deleted from a colwit
  2. Make sure the signatures (CPL/Clavis) are shown in the Canwit details view

Okay, the above is now working