ErwinKomen / RU-passim

0 stars 0 forks source link

Small corrections on AF-detail page #729

Open shariboodts opened 5 months ago

shariboodts commented 5 months ago

Part 1 Small corrections to the AF-detail page (main overhaul was done in the context of issue #635, some other remaining features are signalled in issue #708):

Part 2 Edit: leave this part of the issue out, for now (lower priority)

There are also a number of open issues for the overlap network. If there is time, these can be addressed as well:

512 #598 #645 #646 #647 #651 #652

Irisdenis commented 1 month ago

edit to Part 2 of this issue_

An additional example of a dating graph that is difficult to interpret, or even misleading, is the one for AF https://passim.rich.ru.nl/ssg/details/1931/. The oldest witness to this text is dated to 745-754, and yet the horizontal axis of the dating graph only starts at 800. This is confusing.

ErwinKomen commented 4 weeks ago

edit to Part 2 of this issue_

An additional example of a dating graph that is difficult to interpret, or even misleading, is the one for AF https://passim.rich.ru.nl/ssg/details/1931/. The oldest witness to this text is dated to 745-754, and yet the horizontal axis of the dating graph only starts at 800. This is confusing.

This turned out to have nothing to do with the date graph representation as such. It was because of the daterange being defined in one of three possible places, but not the correct one. I thoroughly repaired this for all manuscripts currently in the database. So this problem should no longer occur.

As for the visualization itself: this follows the example from Trismegistos, which was what was asked for. Changing a visualization is always possible, but it may be better to have that as a separate point. This issue #729 is about 'small AF-detail page' corrections, and a fundamental change in a visualization deserves its own separate issue.

ErwinKomen commented 4 weeks ago

Implementation Part 1

  1. Details view should be expanded by default
    1. Added boolean field show in the mainsections object
    2. This is processed by basic_edit.html
    3. Adapted basic.js to indicate the open/closed state of a button with jumbo-2 versus jumbo-1
  2. Rename button ‘add a new sermon gold’: ‘Add item to equality set’
    1. Change the new_button_title in the context for view EqualGoldEdit
  3. Graphs > Rename button ‘Authors’ to ‘Attrib. authors’
    1. Changed wording in seeker/af_graphs.html
  4. Overlap network > rename ‘overlap network degree’ to ‘overlap network level’
    1. Changed wording in seeker/af_networks.html
  5. Issue #642 (gesloten) werkt nog niet helemaal: het sorteren van AF details > manifestations op datum gebeurt niet chronologisch (800-899 staat nu onder 1400-1499, bijv. https://passim.rich.ru.nl/ssg/details/1493/. De andere sorteeropties werken goed.