search

ErwinKomen / RU-passim

0 stars 0 forks source link

Newly added AF search problem: a bug? #742

Closed glsch closed 6 months ago

glsch commented 6 months ago

Having added a new Authority file, I've encountered two problems:

  1. I cannot retrieve it in any way other than typing in its URL with seeker_equalgold id. Since I can access the page, the record was created correctly. However, it cannot be found neither using Gryson code, nor incipit, nor even PASSIM code.
  2. Similarly, this AF does not become visible in the manifestation-AF linking window. Again, none of the search methods helps.

As far as I can judge, I am doing everything in precisely the same manner as before when I did not have this problem.

Is it a bug? Or should I do something differently if I want to create a new AF and connect it to a manifestation?

ErwinKomen commented 6 months ago

This is connected with the approval system, and probably a side-effect of #730. The newly created AF has received an atype of value def (default). It will only be 'shown' (in searches etc), when its atype is promoted to acc (accepted). Right now it shows up in the user's MyPassim as "My AF project additions/removals/deletions"

It is a bug, because the user has approval rights in both projects to which this new AF belongs, so it should have received the "accepted" atype upon creation.

ErwinKomen commented 6 months ago

Well, I double checked in view EqualGoldDetails, method after_save(), and the behaviour is by design: Any newly created AF, for whom the user is an approver of > 1 projects, needs to be accorded by approvers of those projects. We could change that behaviour, if it is desired.

ErwinKomen commented 6 months ago

P.I:

I think the second solution is the best:

“When someone with editing rights creates a new AF, it is automatically assigned to all the projects that are in MyPassim under by default assign all items that I import to the following project(s)”

ErwinKomen commented 6 months ago

Implementation

  1. Changed 'default' project assignment from ProjectApprover to ProjectEditor
    1. Adapted all relevant references in model Profile and its model methods
  2. One-time adaptation to carry over the default settings for all profiles
  3. Adapted view EqualGoldDetails, the method after_save(): the method "after_issue742" now simply assigns all projects within the user's default ones (those in ProjectEditor with status incl)

Checked, works