ErwinKomen / RU-passim

0 stars 0 forks source link

DCT: bug in specific DCT matches display #745

Closed Irisdenis closed 4 months ago

Irisdenis commented 5 months ago

The number of displayed matches between two manuscripts in a research set, differs in relation to which of the two manuscript is the pivot. This should not happen: i.e. in a DCT of manuscripts A, B and C, there should be the same number of matches between A and B regardless of whether A or B is the pivot. (If C is the pivot, only the matches between C and the other manuscripts should be displayed - that's a different situation).

image

Printscreen 1 (Vat. Lat. 3836 as pivot)

image

Printscreen 2 (Vat. Lat. 3828 as pivot)

ErwinKomen commented 4 months ago

Observations

  1. When clicking "view all", there is a Javascript error lst_exclude is undefined in function dct_row_combine()
    1. That was a mistake in the Javascript. Corrected this, now no error anymore.
  2. What is shown and what not:
    1. When the DCT opens, all non-hidden matches are shown correctly. Note that this DCT has quite a few hidden rows (see JSON below)
    2. When "all rows" are clicked: all rows are shown
    3. When "matches only" is clicked: all matches are shown, and the hidden rows are not hidden
  3. So that begs the question: what are hidden rows, and how do they get there?
    1. They are hidden through the command dct_hiderow()
    2. This command is activated, when someone clicks the minus '-' sign that appears: image
    3. Resolution to this: (a) select "View all", (b) select "mathces only", (c) press Save

The JSON of this DCT:

{"pivot_col":11,
"view_mode":"match",
"col_mode":"custom",
"lst_order":[11,7,9,8,6,5],
"lst_exclude":[1,2,4,3,10],
"hidden_rows":[0,1,2,3,4,5,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,30,31,32,33,34,35,36,38,40,42,43,44,45,48,49,50,52,53,56,58,59,60,62,63,64,65,72,73,74,77,78]}

TODO:

  1. Since the behaviour of 'hidden rows' is by design, this should be explained in the User Guide too. (I didn't check this, but it may be in there already??)