ErwinKomen / RU-passim

0 stars 0 forks source link

Bug: Slider bar functionality does not work for PD's #765

Closed Irisdenis closed 1 month ago

Irisdenis commented 1 month ago

Builds on the completed issue #717

I made a test-personal dataset of three AF's (https://passim.rich.ru.nl/dataset/private/details/1060/) that I would like to compare to the manuscripts in the database.

When I filter this dataset in the 'manuscript' listview, this automatically shows a slider bar (as part of 'comparative search'), which is great! However, the moving of the slider bar does not change the results. If I want to find the manuscripts that contain all three manuscripts (slider bar = 100%), this yields the same amount of manuscripts (88) as the slider bar set to 50% or 5%. See: https://passim.rich.ru.nl/manuscript/list?usersearch=12371

I tested this with another dataset, which gave the same results. For the two other comparative filters (manuscripts and Historical Collections), the slider bar seems to function well.

ErwinKomen commented 1 month ago

Okay, the problem here was in adapt_search(), that basically only looked at collist_hist I now added in preferential order: collist_hist, collist_ssg, cmpmanuidlist.

I also looked at making the value of the range slider show automatically. I fixed that.