Improve GitHub Actions Workflow

ErwinM / acts_as_tenant

Easy multi-tenancy for Rails in a shared database setup.

MIT License

1.56k stars 264 forks source link

Closed matthee closed 3 years ago

matthee commented 3 years ago

This PR improves the way gems are cached in the GitHub Actions Workflow:

Use new version of actions/cache@v2
Specifies the bundle path vendor/bundle, which is required by the cache action
Creates a cache keys based on ruby version. This should help with installing dependencies with native extensions. However, I don't know if this step is actually necessary, but still I consider this a good practice.

matthee commented 3 years ago

Huh, I did not expect these actions to fail. I will investigate further...

excid3 commented 3 years ago

Good call. 👍

I am guessing this conflicts with something Appraisal does.

matthee commented 3 years ago

Jup - there is an open issue on the appraisals repo, which seems to be related: https://github.com/thoughtbot/appraisal/issues/173

excid3 commented 3 years ago

Looking at Appraisal, I can't quite tell what's causing that issue. Might have to work it and see if we can replicate it locally.

excid3 commented 3 years ago

Just merged #244 which spins up a separate job for each Appraisal. Figured it would be easier to see specific Rails failures that way.

I did start a PR for Appraisal, but it needs some work on the tests. https://github.com/thoughtbot/appraisal/pull/174