search

ErwinM / acts_as_tenant

Easy multi-tenancy for Rails in a shared database setup.
MIT License
1.53k stars 263 forks source link

Set GitHub Workflow for multiple DB's #243

Closed MatthewKennedy closed 3 years ago

excid3 commented 3 years ago

Was thinking about it this morning, since ActsAsTenant doesn't really have any database dependencies (it just adds a belongs_to), do you think we'll get any value out of testing against multiple databases?

MatthewKennedy commented 3 years ago

I'll close this PR.

excid3 commented 3 years ago

@MatthewKennedy sorry for the trouble! We definitely could use ruby head added to Actions.

excid3 commented 3 years ago

Forgot I had a PR for Ruby 3.0 in my fork, but it wasn't passing so I had left it. Gonna see if preview2 works better.

MatthewKennedy commented 3 years ago

@excid3 Not a problem, if truth be told I was experimenting with the GitHub Actions, and thought it might be useful on this gem, but MySQL is proving a little troublesome to get working.

excid3 commented 3 years ago

Yeah, not quite sure why it was giving you trouble.

If you want to experiment some more with Actions, here's the PR for Ruby head. I am not sure why it's not passing. Maybe they don't have preview2 in the ruby action yet? https://github.com/excid3/acts_as_tenant/pull/9/files