search

EscVM / OIDv4_ToolKit

Download and visualize single or multiple classes from the huge Open Images v4 dataset
GNU General Public License v3.0
809 stars 635 forks source link

setup.py with installation and console entry point #54

Open monocongo opened 5 years ago

monocongo commented 5 years ago

This PR contains 1) a setup.py file that allows for installation of this package into a Python (virtual) environment via the command:

$ python setup.py install

This setup file also includes a console script entry point named oidv4_toolkit

  1. an updated requirements.txt file containing the results of pip freeze
  2. various cleanups (formatting, removal of unused imports, etc.) for better PEP8 compliance
  3. package can now be registered and uploaded to PyPI using method outlined in the initial comment for issue #52
  4. valid .gitignore file
keldrom commented 5 years ago

There are changes that I don't approve (like changing the name of the classes)

monocongo commented 5 years ago

The package name should be something more specific than "modules", i.e., something that identifies the package so when you import modules from it then it's obvious what package you're importing from. At least that's how every other serious package does it anyway. For example, if you import OpenCV you use import cv2 or from requests you use from requests import *, etc.