search

EscanBE / evermint

Evermint is a fork of open source Evmos, maintains bug fixes, customization and enable developers to fork and transform to their chain, fully customized naming, in just 2 steps. For research and development purpose.
GNU Lesser General Public License v3.0
3 stars 3 forks source link

Problem: transaction receipt `cumulativeGasUsed` might facing bug #101

Closed VictorTrustyDev closed 3 months ago

VictorTrustyDev commented 10 months ago

I feel wrong about this implementation...

    cumulativeGasUsed := res.GasUsed
    if ctx.BlockGasMeter() != nil {
        limit := ctx.BlockGasMeter().Limit()
        cumulativeGasUsed += ctx.BlockGasMeter().GasConsumed()
        if cumulativeGasUsed > limit {
            cumulativeGasUsed = limit
        }
    }

So I dropped a note here and review later.

VictorTrustyDev commented 3 months ago

Fixed by #132