EscanBE / evermint

Evermint is a fork of open source Evmos, maintains bug fixes, customization and enable developers to fork and transform to their chain, fully customized naming, in just 2 steps. For research and development purpose.
GNU Lesser General Public License v3.0
3 stars 3 forks source link

Problem: possible wrong refund EVM tx implementation #123

Closed VictorTrustyDev closed 3 months ago

VictorTrustyDev commented 3 months ago

What Ethereum does:

After state transition, gas refund amount is get from state transition, then
- Refund fee to sender based on the refund amount
- ...

What Evermint/Ethermint/Evmos-fork does:

After state transition, gas refund amount is get from state transition, then
- Minus from gas used
- Refund fee to sender based on refund = `tx gas - gas consumed`

Ethereum actually refunds a little gas while Evermint refunds a lot of gas, that make it have to have additional logic like MinGasMultiplier in x/feemarket params.

VictorTrustyDev commented 3 months ago

This is wrong