search

Escape-Technologies / mookme

A pre-commit tool designed for monorepos.
MIT License
100 stars 16 forks source link

The file arguments account for deleted files as well #82

Open LMaxence opened 2 years ago

LMaxence commented 2 years ago

When using the argument {matchedFiles} for instance in a hook, it will list changed file of the package as expected, but it will also list deleted files, leading to errors sometimes.

Here, the file ` was deleted which breaks my pre-commit hook and made me do a commit--no-verify`.

image
jeffvswanson commented 1 year ago

I happened across this bug as well with renamed python files in mookme version 2.3.0.

jfb-workhelix commented 2 months ago

I opened a very primitive PR to fix this:

https://github.com/Escape-Technologies/mookme/pull/132

arthurio commented 1 month ago

Fixed by https://github.com/Escape-Technologies/mookme/pull/132