search

EscapeRoomsCommunity / escape_roomba

A Discord bot to bring ease and joy to the Escape Room community discord.
MIT License
1 stars 2 forks source link

Refactor ThreadManager to split out ThreadChannel logic #9

Closed egnor closed 4 years ago

egnor commented 4 years ago

Still needs more testing (both a unit test and manual testing), but please take a look to verify this improves the complexity that was hard to understand previously. No functionality changes.

egnor commented 4 years ago

I wasn't sure from your PR description if you were meaning to add tests to this PR after a first review pass, or not, but generally this seems good enough to merge. I haven't reviewed the code here in super-fine detail, but in structure it does seem like an improvement.

I figure that would be a follow-up at some point...