Escartem / AnimeWwise

Extract audio from those anime games with original filenames, paths and more
48 stars 7 forks source link

add ogg argument support #5

Closed dromzeh closed 9 months ago

dromzeh commented 9 months ago

yo

made this as for my own use case - completely up to you if you want to merge but might be useful for those who are looking for something lightweight (like this CLI) and want to export in another format?

tbh this could be added onto like --output ogg for example (i can change it if you would prefer lol)

Code_fXRdT2MYGh

Escartem commented 9 months ago

ty for this pull request, like said in the readme I wanted to add ogg support but never actually did it, I'll take a look and merge it soon :)

dromzeh commented 9 months ago

ty for this pull request, like said in the readme I wanted to add ogg support but never actually did it, I'll take a look and merge it soon :)

yeah, no worries man

if you were looking to expand this support than just additional ogg i can rewrite it to --output [format] then create a map for format => codec (e.g ogg => libvorbis) ? whatever u prefer lol

Escartem commented 9 months ago

All formats won't necessarily be a ffmpeg lib but I guess ogg is good enough for now

Escartem commented 9 months ago

i've modified the file to use an audio format instead, might be better

Escartem commented 9 months ago

looking pretty good overall, I'll do some tests and merge it when I have a bit of time